lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 3 Dec 2013 14:20:20 +0000 From: Wei Liu <wei.liu2@...rix.com> To: Paul Durrant <paul.durrant@...rix.com> CC: <xen-devel@...ts.xen.org>, <netdev@...r.kernel.org>, Wei Liu <wei.liu2@...rix.com>, Ian Campbell <ian.campbell@...rix.com>, David Vrabel <david.vrabel@...rix.com> Subject: Re: [PATCH net v2] xen-netback: clear vif->task on disconnect On Tue, Dec 03, 2013 at 02:06:25PM +0000, Paul Durrant wrote: > xenvif_start_xmit() relies on checking vif->task for NULL to determine > whether the vif is ready to accept packets. The task thread is stopped in > xenvif_disconnect() but task is not set to NULL. Thus, on a re-connect the > check will give a false positive. > > Also since commit ea732dff5cfa10789007bf4a5b935388a0bb2a8f (Handle backend > state transitions in a more robust way) it should not be possible for > xenvif_connect() to be called if the vif is already connected so change the > check of vif->tx_irq to a BUG_ON() and also add a BUG_ON(vif->task). > > Signed-off-by: Paul Durrant <paul.durrant@...rix.com> > Cc: Wei Liu <wei.liu2@...rix.com> > Cc: Ian Campbell <ian.campbell@...rix.com> > Cc: David Vrabel <david.vrabel@...rix.com> Acked-by: Wei Liu <wei.liu2@...rix.com> Thanks Wei. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists