netdev - Re: [PATCH net v4 1/2] net: sched: tbf: fix calculation of max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1386082293.30495.26.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 03 Dec 2013 06:51:33 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Yang Yingliang <yangyingliang@...wei.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, brouer@...hat.com,
	jpirko@...hat.com, jbrouer@...hat.com
Subject: Re: [PATCH net v4 1/2] net: sched: tbf: fix calculation of max_size

On Tue, 2013-12-03 at 19:32 +0800, Yang Yingliang wrote:

> > 
> >>
> >> TSO packet of 64KB -> about 45 frames if MSS=1448, 45*1514 = 68130 bytes
> 
> Maybe MAX_PKT_LEN should be much bigger. Hmm, I'm uncertain how big is the proper value.
> 

Thats the thing : When user is able to compute the appropriate burst and
give precise instructions to the kernel, why tbf would reduce it to
whatever fixed threshold ?

If I set 200000 as a burst, I do not want tbf use 65536 or even less.

If tbf rounds my 200000 to 199800, its fine.

You had problems to set burst to appropriate values, but most other
users did that fine.

tbf_segment() is an attempt to help for very low rates, to not overcome
the small bursts (as low as 2000 bytes) programmed on atbf qdisc, but
for high rates, we _definitely_ want to avoid segmentation as hell.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html