netdev - Re: [PATCH] xen/pvhvm: If xen_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131204164802.GG391@pegasus.dumpdata.com>
Date:	Wed, 4 Dec 2013 11:48:03 -0500
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	stefano.stabellini@...citrix.com, ian.campbell@...rix.com,
	xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org,
	boris.ostrovsky@...cle.com, david.vrabel@...rix.com,
	leosilva@...ux.vnet.ibm.com, ashley@...leylai.com,
	peterhuewe@....de, mail@...jiv.net, tpmdd@...horst.net,
	tpmdd@...rix.com, bhelgaas@...gle.com, plagnioj@...osoft.com,
	tomi.valkeinen@...com, tpmdd-devel@...ts.sourceforge.net,
	linux-input@...r.kernel.org, netdev@...r.kernel.org,
	linux-pci@...r.kernel.org, linux-fbdev@...r.kernel.org
Subject: Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.

> > which is hardly nice. This patch fixes this by having each
> > PV driver check for:
> >  - if running in PV, then it is fine to execute (as that is their
> >    native environment).
> >  - if running in HVM, check if user wanted 'xen_emul_unplug=never',
> >    in which case bail out and don't load PV drivers.
> >  - if running in HVM, and if PCI device 5853:0001 (xen_platform_pci)
> >    does not exist, then bail out and not load PV drivers.
> > 
> > P.S.
> > Ian Campbell suggested getting rid of 'xen_platform_pci_unplug'
> > but unfortunatly the xen-blkfront driver is using it, so we
> > cannot do it.
> > 
> > Reported-by: Sander Eikelenboom <linux@...elenboom.it
> > Reported-by: Anthony PERARD <anthony.perard@...rix.com>
> > Reported-by: Fabio Fantoni <fabio.fantoni@....biz>
> 
> For input:
> 
> Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Thank you. I need to do some extra changes to the other subsystems but
for the fb/kbd itshould be still throught the same function as this
patch has exposed. I will repost it and include your Ack if you are OK
with that?
> 
> ...
> 
> > +#if defined(CONFIG_XEN_PVHVM)
> > +extern bool xen_has_pv_devices(void);
> > +#else
> > +static inline bool xen_has_pv_devices(void)
> > +{
> > +#if defined(CONFIG_XEN)
> > +	return true;
> > +#else
> > +	return false;
> > +#endif
> 
> 	return IS_ENABLED(CONFIG_XEN);
> 
> ?

Oh, awesome!  Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html