netdev - 2e685cad5790 build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Dec 2013 17:29:43 -0500
From:	Johannes Weiner <hannes@...xchg.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Glauber Costa <glommer@...il.com>, netdev@...r.kernel.org,
	linux-mm@...ck.org, linux-kernel@...ck.org
Subject: 2e685cad5790 build warning

Hi Eric,

commit 2e685cad57906e19add7189b5ff49dfb6aaa21d3
Author: Eric W. Biederman <ebiederm@...ssion.com>
Date:   Sat Oct 19 16:26:19 2013 -0700

    tcp_memcontrol: Kill struct tcp_memcontrol
    
    Replace the pointers in struct cg_proto with actual data fields and kill
    struct tcp_memcontrol as it is not fully redundant.
    
    This removes a confusing, unnecessary layer of abstraction.
    
    Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>

triggers a build warning because it removed the only reference to a
function but not the function itself:

linux/net/ipv4/tcp_memcontrol.c:9:13: warning: ‘memcg_tcp_enter_memory_pressure’ defined but not used [-Wunused-function]
 static void memcg_tcp_enter_memory_pressure(struct sock *sk)

I can not see from the changelog why this function is no longer used,
or who is supposed to now set cg_proto->memory_pressure which you
still initialize etc.  Either way, the current state does not seem to
make much sense.  The author would be the best person to double check
such changes, but he wasn't copied on your patch, so I copied him now.

Apologies if this has been brought up before, I could not find any
reference on LKML of either this patch or a report of this warning.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html