netdev - Re: 2e685cad5790 build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131204.175028.1602944177771517327.davem@davemloft.net>
Date:	Wed, 04 Dec 2013 17:50:28 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hannes@...xchg.org
Cc:	ebiederm@...ssion.com, glommer@...il.com, netdev@...r.kernel.org,
	linux-mm@...ck.org, linux-kernel@...ck.org
Subject: Re: 2e685cad5790 build warning

From: Johannes Weiner <hannes@...xchg.org>
Date: Wed, 4 Dec 2013 17:29:43 -0500

> linux/net/ipv4/tcp_memcontrol.c:9:13: warning: ‘memcg_tcp_enter_memory_pressure’ defined but not used [-Wunused-function]
>  static void memcg_tcp_enter_memory_pressure(struct sock *sk)

Also, amusingly, although static there is an EXPORT_SYMBOL() for it.

> 
> I can not see from the changelog why this function is no longer used,
> or who is supposed to now set cg_proto->memory_pressure which you
> still initialize etc.  Either way, the current state does not seem to
> make much sense.  The author would be the best person to double check
> such changes, but he wasn't copied on your patch, so I copied him now.

Eric, please resolve this.