netdev - Re: [PATCH] sctp: disable max_burst when the max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <529EEE70.7090801@redhat.com>
Date:	Wed, 04 Dec 2013 09:57:20 +0100
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Wang Weidong <wangweidong1@...wei.com>
CC:	David Miller <davem@...emloft.net>,
	Neil Horman <nhorman@...driver.com>,
	Vlad Yasevich <vyasevich@...il.com>,
	Michael Tuexen <Michael.Tuexen@...chi.franken.de>,
	linux-sctp@...r.kernel.org, netdev@...r.kernel.org,
	dingtianhong@...wei.com
Subject: Re: [PATCH] sctp: disable max_burst when the max_burst is 0

On 12/03/2013 07:30 AM, Wang Weidong wrote:
> As Michael pointed out that when max_burst is 0, it just disable
> max_burst. It declared in rfc6458#section-8.1.24. so add the check
> in sctp_transport_burst_limited, when it 0, just do nothing.
>
> Suggested-by: Vlad Yasevich <vyasevich@...il.com>
> Suggested-by: Michael Tuexen <Michael.Tuexen@...chi.franken.de>
> Signed-off-by: Wang Weidong <wangweidong1@...wei.com>
> ---
>   net/sctp/transport.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/sctp/transport.c b/net/sctp/transport.c
> index e332efb..e580e34 100644
> --- a/net/sctp/transport.c
> +++ b/net/sctp/transport.c
> @@ -573,7 +573,8 @@ void sctp_transport_burst_limited(struct sctp_transport *t)
>   	u32 old_cwnd = t->cwnd;
>   	u32 max_burst_bytes;
>
> -	if (t->burst_limited)
> +	/* if the max_burst is 0, do notihing */
> +	if (t->burst_limited || !asoc->max_burst)
>   		return;

Minor nitpick ... you can remove the comment as it contains a typo and
basically says what the code is doing anyway, so you could instead make
the code a bit more clear for readers e.g. "asoc->max_burst == 0".

>   	max_burst_bytes = t->flight_size + (asoc->max_burst * asoc->pathmtu);
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html