netdev - Re: [PATCH v2] sctp: disable max_burst when the max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <529F3BF3.40009@gmail.com>
Date:	Wed, 04 Dec 2013 09:28:03 -0500
From:	Vlad Yasevich <vyasevich@...il.com>
To:	Wang Weidong <wangweidong1@...wei.com>, nhorman@...driver.com,
	David Miller <davem@...emloft.net>
CC:	linux-sctp@...r.kernel.org, netdev@...r.kernel.org,
	Daniel Borkmann <dborkman@...hat.com>
Subject: Re: [PATCH v2] sctp: disable max_burst when the max_burst is 0

On 12/04/2013 04:32 AM, Wang Weidong wrote:
> As Michael pointed out that when max_burst is 0, it just disable
> max_burst. It declared in rfc6458#section-8.1.24. so add the check
> in sctp_transport_burst_limited, when it 0, just do nothing.
> 
> Reviewed-by: Daniel Borkmann <dborkman@...hat.com>
> Suggested-by: Vlad Yasevich <vyasevich@...il.com>
> Suggested-by: Michael Tuexen <Michael.Tuexen@...chi.franken.de>
> Signed-off-by: Wang Weidong <wangweidong1@...wei.com>
> ---
>  net/sctp/transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sctp/transport.c b/net/sctp/transport.c
> index e332efb..efc46ff 100644
> --- a/net/sctp/transport.c
> +++ b/net/sctp/transport.c
> @@ -573,7 +573,7 @@ void sctp_transport_burst_limited(struct sctp_transport *t)
>  	u32 old_cwnd = t->cwnd;
>  	u32 max_burst_bytes;
>  
> -	if (t->burst_limited)
> +	if (t->burst_limited || asoc->max_burst == 0)
>  		return;
>  
>  	max_burst_bytes = t->flight_size + (asoc->max_burst * asoc->pathmtu);
> 

Acked-by: Vlad Yasevich <vyasevich@...il.com>

Thanks
-vlad
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html