netdev - [PATCH] mvneta: DMA API misusage fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1386261337-26442-1-git-send-email-ezequiel.garcia@free-electrons.com>
Date:	Thu,  5 Dec 2013 13:35:36 -0300
From:	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
To:	<netdev@...r.kernel.org>
Cc:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	Gregory Clement <gregory.clement@...e-electrons.com>,
	Lior Amsalem <alior@...vell.com>, Willy Tarreau <w@....eu>,
	Jason Cooper <jason@...edaemon.net>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Andrew Lunn <andrew@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
Subject: [PATCH] mvneta: DMA API misusage fix

This small patch removes a DMA_API_DEBUG warning, fixing a DMA API misusage.
The change is straightforward: rx DMA mappings are created setting a size
(using some upper-limit buffer size), but destroyed (aka unmapped) setting
the actual data size that was received.

The fix replaces 'data_size' by the MVNETA_RX_BUF_SIZE in the unmap.

I'm not sure how serious this misusage is, so I'd like to ask for advise
about marking this commit for stable. The problem is here since the
introduction of the driver, namely since:

  commit c5aff18204da025fdf714f8f6423372b4b8efd00
  net: mvneta: driver for Marvell Armada 370/XP network unit

Thanks!

Ezequiel Garcia (1):
  net: mvneta: Fix incorrect DMA unmapping size

 drivers/net/ethernet/marvell/mvneta.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
1.8.1.5

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html