netdev - Re: [PATCH net] bonding: fix packets_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1386248615.30495.184.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 05 Dec 2013 05:03:35 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Veaceslav Falico <vfalico@...hat.com>
Cc:	Nikolay Aleksandrov <nikolay@...hat.com>, netdev@...r.kernel.org,
	Andy Gospodarek <andy@...yhouse.net>,
	Jay Vosburgh <fubar@...ibm.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] bonding: fix packets_per_slave showing

On Thu, 2013-12-05 at 13:42 +0100, Veaceslav Falico wrote:
> .
> 
> Hrm? bond_check_params() isn't involved in sysfs at all :-/, it's called
> only via bonding_init(). And bond->params.packets_per_slave isn't read
> there at all, only assigned.
> 
> Or, given the naming confusions, I'm again missing something?

This is so confusing.

If the check was done properly, we could expose the value
in /sys/module/bonding/parameters/packets_per_slave

So that you can change the setting without reloading the module.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html