netdev - Re: [net-next PATCH 3/6] macvtap: remove the dead branch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131206.114602.2053541753179744731.davem@davemloft.net>
Date:	Fri, 06 Dec 2013 11:46:02 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	linux@...ck-us.net
Cc:	zwu.kernel@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, wuzhy@...ux.vnet.ibm.com
Subject: Re: [net-next PATCH 3/6] macvtap: remove the dead branch

From: Guenter Roeck <linux@...ck-us.net>
Date: Thu, 05 Dec 2013 22:08:20 -0800

> Assigning the function's return value to ret just to ignore it seems
> odd.
> 
> Might make sense to change the function type to void.

That's exactly what his very next patch does, undoubtedly the two
patches should be combined into one.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html