netdev - Re: [PATCH] tcp_memcontrol: Cleanup/fix cg_proto->memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131205.210122.1665109336067593941.davem@davemloft.net>
Date:	Thu, 05 Dec 2013 21:01:22 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	hannes@...xchg.org, glommer@...il.com, netdev@...r.kernel.org,
	linux-mm@...ck.org, linux-kernel@...ck.org
Subject: Re: [PATCH] tcp_memcontrol: Cleanup/fix cg_proto->memory_pressure
 handling.

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Wed, 04 Dec 2013 20:12:04 -0800

> 
> kill memcg_tcp_enter_memory_pressure.  The only function of
> memcg_tcp_enter_memory_pressure was to reduce deal with the
> unnecessary abstraction that was tcp_memcontrol.  Now that struct
> tcp_memcontrol is gone remove this unnecessary function, the
> unnecessary function pointer, and modify sk_enter_memory_pressure to
> set this field directly, just as sk_leave_memory_pressure cleas this
> field directly.
> 
> This fixes a small bug I intruduced when killing struct tcp_memcontrol
> that caused memcg_tcp_enter_memory_pressure to never be called and
> thus failed to ever set cg_proto->memory_pressure.
> 
> Remove the cg_proto enter_memory_pressure function as it now serves
> no useful purpose.
> 
> Don't test cg_proto->memory_presser in sk_leave_memory_pressure before
> clearing it.  The test was originally there to ensure that the pointer
> was non-NULL.  Now that cg_proto is not a pointer the pointer does not
> matter.
> 
> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html