netdev - Re: [PATCH net v5 1/2] net: sched: tbf: fix calculation of max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52A14B16.6050209@huawei.com>
Date:	Fri, 6 Dec 2013 11:57:10 +0800
From:	Yang Yingliang <yangyingliang@...wei.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<brouer@...hat.com>, <jpirko@...hat.com>, <jbrouer@...hat.com>
Subject: Re: [PATCH net v5 1/2] net: sched: tbf: fix calculation of max_size

On 2013/12/6 11:46, Eric Dumazet wrote:
> On Fri, 2013-12-06 at 10:24 +0800, Yang Yingliang wrote:
>> Hi, Eric
>> Thanks for your reviewing and advice!
>>
>> On 2013/12/5 20:15, Eric Dumazet wrote:
>>> On Thu, 2013-12-05 at 15:10 +0800, Yang Yingliang wrote:
>>>>
>>>> Suggested-by: Jesper Dangaard Brouer <jbrouer@...hat.com>
>>>> Suggested-by: Eric Dumazet <edumazet@...gle.com>
>>>
>>> No, I did not suggest this patch.
>>
>> You suggested that
>>
>> 	if (qopt->rate.linklayer == TC_LINKLAYER_UNAWARE)
>> 	    qdisc_put_rtab(qdisc_get_rtab(&qopt->rate,
>> 				          tb[TCA_TBF_RTAB]));
>>
>> so I added your suggestion.
> 
> OK : The exact meaning of 'Suggested-by: XX' is :
> 
> 1) the patch idea was given by XX.
> 2) Then you implemented it.
> 
> This is not really the case here : You had the idea of this patch.
> 
> I made some feedbacks, you have no special tag to add for that.
> 
> Later, if I agree with your next patch set I'll add my own
> "Acked-by: ..."
> 
> If not (for example I am slow to respond and it got merged), its not a
> big deal.
> 
> Thanks
> 

Got it.
Thanks for your explanation!

> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html