netdev - Re: Fw: [Bug 66691] New: iproute2: macvlan: Wrong root device shown if in different netns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXs5wXr-7vgmT39__cJ0xo3D4fFOkfmd4_C-5+zPAKGeWZugA@mail.gmail.com>
Date:	Sat, 7 Dec 2013 11:18:52 +0200
From:	Kevin Wilson <wkevils@...il.com>
To:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: Fw: [Bug 66691] New: iproute2: macvlan: Wrong root device shown
 if in different netns

Hi,
Shouldn't the macvlan be network nsmespace local device, like the vlan
and VXLAN device (which have NETIF_F_NETNS set)?
When a nework device has the NETIF_F_NETNS flag set, it cannot be
moved from one network namespace to another.

Kevin W.

On Sat, Dec 7, 2013 at 1:38 AM, Kevin Wilson <wkevils@...il.com> wrote:
> Hi,
> Shouldnt the macvlan be network nsmespace local device, like the vlan and
> vxlan device (which have NETIF_F_NETNS set)?
>
>
> On Friday, December 6, 2013, Stephen Hemminger <stephen@...workplumber.org>
> wrote:
>> This isn't a iproute2 bug, it is only reporting what the kernel tells it
>>
>> Begin forwarded message:
>>
>> Date: Fri, 6 Dec 2013 00:07:15 -0800
>> From: "bugzilla-daemon@...zilla.kernel.org"
>> <bugzilla-daemon@...zilla.kernel.org>
>> To: "stephen@...workplumber.org" <stephen@...workplumber.org>
>> Subject: [Bug 66691] New: iproute2: macvlan: Wrong root device shown if in
>> different netns
>>
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=66691
>>
>>             Bug ID: 66691
>>            Summary: iproute2: macvlan: Wrong root device shown if in
>>                     different netns
>>            Product: Networking
>>            Version: 2.5
>>     Kernel Version: 3.10
>>           Hardware: All
>>                 OS: Linux
>>               Tree: Mainline
>>             Status: NEW
>>           Severity: normal
>>           Priority: P1
>>          Component: Other
>>           Assignee: shemminger@...ux-foundation.org
>>           Reporter: helmut.schaa@...glemail.com
>>         Regression: No
>>
>> In the root net namespace if have the following devices:
>>
>>> ip link
>> [...]
>> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state
>> UP
>> mode DEFAULT group default qlen 1000
>>     link/ether xx:xx:xx:xx:xx:xx brd ff:ff:ff:ff:ff:ff
>> 3: gre0: <NOARP> mtu 1476 qdisc noop state DOWN mode DEFAULT group default
>>     link/gre 0.0.0.0 brd 0.0.0.0
>> [...]
>>
>> Let's add a macvlan on top of eth0:
>>
>>> ip link
>> [...]
>> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state
>> UP
>> mode DEFAULT group default qlen 1000
>>     link/ether xx:xx:xx:xx:xx:xx brd ff:ff:ff:ff:ff:ff
>> 3: gre0: <NOARP> mtu 1476 qdisc noop state DOWN mode DEFAULT group default
>>     link/gre 0.0.0.0 brd 0.0.0.0
>> [...]
>> 17: mac0@...0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode
>> DEFAULT group default
>>     link/ether 46:aa:b4:fb:44:a6 brd ff:ff:ff:ff:ff:ff
>>
>> And now lets move it into its own net namespace and list the devices in
>> the new
>> namespace.
>>
>>> ip link set mac0 netns myns
>>> ip netns exec myns ip link
>> [...]
>> 2: gre0: <NOARP> mtu 1476 qdisc noop state DOWN mode DEFAULT group default
>>     link/gre 0.0.0.0 brd 0.0.0.0
>> [...]
>> 17: mac0@...0: <BROADCAST,MULTICAST,M-DOWN> mtu 1500 qdisc noop state DOWN
>> mode
>> DEFAULT group default
>>     link/ether 46:aa:b4:fb:44:a6 brd ff:ff:ff:ff:ff:ff
>>
>> mac0 shows gre0 as its base device which is not correct. However gre0 has
>> the
>> same ifindex in the new namespace as eth0 in the root namespace and the
>> ifindex
>> is used for finding the base device.
>>
>> commit aa79e66eee5d525e2fcbd2a5fcb87ae3dd4aa9e9 "net: Make ifindex
>> generation
>> per-net namespace" changed the ifindex generation to only be unique within
>> a
>> namespace.
>>
>> --
>> You are receiving this mail because:
>> You are the assignee for the bug.
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html