netdev - Re: [net-next 09/14] i40e: Enable all PCTYPEs except FCOE for RSS.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52A36235.1040406@cogentembedded.com>
Date:	Sat, 07 Dec 2013 22:00:21 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>, davem@...emloft.net
CC:	Anjali Singhai Jain <anjali.singhai@...el.com>,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com,
	Jesse Brandeburg <jesse.brandeburg@...el.com>
Subject: Re: [net-next 09/14] i40e: Enable all PCTYPEs except FCOE for RSS.

Hello.

On 07-12-2013 6:17, Jeff Kirsher wrote:

> From: Anjali Singhai Jain <anjali.singhai@...el.com>

> RSS can steer packets based on recognition of all
> sorts of different headers.  Enable some more of them.

> Change-Id: I2264dedae66fb0bceca6fb6e772e050e3ca8efc8

    This line has no place in the upstream patches, and I'm seeing it in 
several patches of this series.

> Signed-off-by: Anjali Singhai Jain <anjali.singhai@...el.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Tested-by: Kavindya Deegala <kavindya.s.deegala@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>   drivers/net/ethernet/intel/i40e/i40e_main.c | 38 ++++++++++++++++++-----------
>   1 file changed, 24 insertions(+), 14 deletions(-)

> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index 273db99..40c64c4 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -5615,15 +5615,34 @@ static int i40e_setup_misc_vector(struct i40e_pf *pf)
>    **/
>   static int i40e_config_rss(struct i40e_pf *pf)
>   {
> -	struct i40e_hw *hw = &pf->hw;
> -	u32 lut = 0;
> -	int i, j;
> -	u64 hena;
> +	const u64 default_hena =
> +			((u64)1 << I40E_FILTER_PCTYPE_NONF_UNICAST_IPV4_UDP) |

    1ULL not good enough?

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html