netdev - Re: [PATCH net-next 07/12] net/mlx4_en: Configure the XPS queue mapping on driver load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52A4936F.3040004@mellanox.com>
Date:	Sun, 8 Dec 2013 17:42:39 +0200
From:	Amir Vadai <amirv@...lanox.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	"David S. Miller" <davem@...emloft.net>
CC:	Or Gerlitz <ogerlitz@...lanox.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	<netdev@...r.kernel.org>, Ido Shamay <idos@...lanox.com>
Subject: Re: [PATCH net-next 07/12] net/mlx4_en: Configure the XPS queue mapping
 on driver load

On 08/12/2013 17:28, Sergei Shtylyov wrote:
> Hello.
> 
> On 08-12-2013 16:35, Amir Vadai wrote:
> 
>> From: Ido Shamay <idos@...lanox.com>
> 
>> Only TX rings of User Piority 0 are mapped.
>> TX rings of other UP's are using UP 0 mapping.
>> XPS is not in use when num_tc is set.
> 
>> Signed-off-by: Ido Shamay <idos@...lanox.com>
>> Signed-off-by: Amir Vadai <amirv@...lanox.com>
> [...]
> 
>> diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
>> b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
>> index fa33a83..a4cdd7d 100644
>> --- a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
>> +++ b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
> [...]
>> @@ -708,8 +710,9 @@ u16 mlx4_en_select_queue(struct net_device *dev,
>> struct sk_buff *skb);
>>   netdev_tx_t mlx4_en_xmit(struct sk_buff *skb, struct net_device *dev);
>>
>>   int mlx4_en_create_tx_ring(struct mlx4_en_priv *priv,
>> -               struct mlx4_en_tx_ring **pring,
>> -               int qpn, u32 size, u16 stride, int node);
>> +            struct mlx4_en_tx_ring **pring,
>> +            int qpn, u32 size, u16 stride,
>> +            int node, int queue_index);
> 
>    Why you've changed the indentation here -- it was alright before.
Right - changed by mistake. Will be fixed in V1.

> 
>>   void mlx4_en_destroy_tx_ring(struct mlx4_en_priv *priv,
>>                    struct mlx4_en_tx_ring **pring);
>>   int mlx4_en_activate_tx_ring(struct mlx4_en_priv *priv,
> 
> WBR, Sergei
> 

Amir
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html