netdev - Re: [RFC] virtio_net: multicast address list never sent to host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131208114319.31ac0e27@nehalam.linuxnetplumber.net>
Date:	Sun, 8 Dec 2013 11:43:19 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	Alex Williamson <alex.williamson@...com>,
	Rusty Russell <rusty@...tcorp.com.au>, netdev@...r.kernel.org
Subject: Re: [RFC] virtio_net: multicast address list never sent to host

On Sun, 8 Dec 2013 14:35:26 +0200
"Michael S. Tsirkin" <mst@...hat.com> wrote:

> On Thu, Dec 05, 2013 at 03:20:52PM -0800, Stephen Hemminger wrote:
> > 
> > The virtio_net driver never sends the second address list to
> > the host. This is because send command takes a pointer to scatter list
> > to send but only inserts that one entry into the scatter list that
> > is sent to the host.
> > 
> > This bug has been there since:
> > commit f565a7c259d71cc186753653d978c646d2354b36
> > Author: Alex Williamson <alex.williamson@...com>
> > Date:   Wed Feb 4 09:02:45 2009 +0000
> > 
> >     virtio_net: Add a MAC filter table
> > 
> > 
> > I also dropped the in argument since it is never used.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
> 
> Indeed. Good catch.
> 
> Acked-by: Michael S. Tsirkin <mst@...hat.com>
> 
> but I think this needs to be submitted formally
> without the RFC tag for dave to include it.
> 
> It's also needed for stable I think?
> 

Not sure if anyone was actually using it. Don't like to put things to stable
unless people are seeing bug. It could be that doing this would breaks some
incorrect host implementation of virtio that was assuming original behaviour.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html