netdev - Re: [PATCH net-next] net-gro: Prepare GRO stack for the upcoming tunneling support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1386558820.30495.313.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Sun, 08 Dec 2013 19:13:40 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Jerry Chu <hkchu@...gle.com>, Eric Dumazet <edumazet@...gle.com>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net-gro: Prepare GRO stack for the upcoming
 tunneling support

On Mon, 2013-12-09 at 11:08 +0800, Herbert Xu wrote:
> On Sun, Dec 08, 2013 at 07:04:23PM -0800, Eric Dumazet wrote:
> > On Mon, 2013-12-09 at 10:48 +0800, Jerry Chu wrote:
> > 
> > > Not sure why ingress qdisc - it seems that qdisc_pkt_len_init() is only called
> > > by the egress path (__dev_xmit_skb())
> > > .
> > 
> > Yeah, Qdisc was meant to be used for egress.
> > 
> > Then to get qdisc for ingress, we use IFB to reinject packets through
> > the qdisc layer.
> 
> I don't think anything outside of GRO should be using the fields set
> by GRO.  If they were doing it implicitly before they should be
> fixed.  After all, they would be broken by something as simple
> as turning GRO off through ethtool, no?

Thats not what I said.

Please read 1def9238d4aa2146924994aa4b7dc861f03b9362 changelog
for details.

If GRO is off, of course qdisc_pkt_len_init() has no problem.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html