netdev - Re: [PATCH 1/1] drivers: net : cpsw: Use netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52A58D61.9060404@ti.com>
Date:	Mon, 9 Dec 2013 14:59:05 +0530
From:	Mugunthan V N <mugunthanvnm@...com>
To:	David Miller <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<george.cherian@...com>
Subject: Re: [PATCH 1/1] drivers: net : cpsw: Use netdev_name while requesting
 irq

On Saturday 07 December 2013 02:16 AM, David Miller wrote:
> From: Mugunthan V N <mugunthanvnm@...com>
> Date: Fri, 6 Dec 2013 12:28:27 +0530
>
>> From: George Cherian <george.cherian@...com>
>>
>> Use netdev_name while requesting irq so that eth* name is shown
>> in /proc/interrupts. Previously it was showing device name as (null)
>> for cpsw interrupts. For using netdev_name register_netdev and then
>> call devm_request_irq.
>>
>> Signed-off-by: George Cherian <george.cherian@...com>
>> Signed-off-by: Mugunthan V N <mugunthanvnm@...com>
> Why is it showing "(null)" as the name, is dev_name() not working
> properly for this device?
>
> The only change you are making is passing netdev_name() instead
> of dev_name().  dev_name() giving NULL doesn't make much sense
> to me.
priv->dev is a network device which is registered to network stack after
request interrupt, so dev name is null, with this patch request
interrupt is moved below after registering the network device with the
network

Initial driver was using DT node name for the interrupts, but with the
devm changes by Daniel Mack in commit 50a5fb068 it was changed to ndev
name which introduced this issue.

Regards
Mugunthan V N
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html