netdev - Re: [patch net-next v2 0/5] neigh: respect default parms values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131209115226.GA1206@gondor.apana.org.au>
Date:	Mon, 9 Dec 2013 19:52:27 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, kuznet@....inr.ac.ru,
	jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net,
	hannes@...essinduktion.org, bcrl@...ck.org, gaofeng@...fujitsu.com,
	joe@...ches.com
Subject: Re: [patch net-next v2 0/5] neigh: respect default parms values

On Sat, Dec 07, 2013 at 07:26:52PM +0100, Jiri Pirko wrote:
> This is a long standing regression. But since the patchset is bigger and
> the regression happened in 2007, I'm proposing this to net-next instead.
> 
> Basically the problem is that if user wants to use /etc/sysctl.conf to specify
> default values of neigh related params, he is not able to do that.
> 
> The reason is that the default values are copied to dev instance right after
> netdev is registered. And that is way to early. The original behaviour
> for ipv4 was that this happened after first address was assigned to device.
> For ipv6 this was apparently from the very beginning.
> 
> So this patchset basically reverts the behaviour back to what it was in 2007 for
> ipv4 and changes the behaviour for ipv6 so they are both the same.
> 
> v1->v2:
> - use neigh_parms->tbl->family as suggested by davem
> 
> Jiri Pirko (5):
>   neigh: convert parms to an array
>   neigh: wrap proc dointvec functions
>   neigh: use tbl->family to distinguish ipv4 from ipv6
>   neigh: restore old behaviour of default parms values
>   neigh: ipv6: respect default values set before an address is assigned
>     to device

I haven't studied the patches in detail but the idea certainly
sounds good to me.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html