netdev - Re: [PATCH net-next v2 6/9] net: mv643xx_eth: use phy_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 09 Dec 2013 21:09:27 +0100
From:	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
To:	Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
CC:	davem@...emloft.net, sergei.shtylyov@...entembedded.com,
	afleming@...il.com, kyle@...fetthome.net
Subject: Re: [PATCH net-next v2 6/9] net: mv643xx_eth: use phy_init_hw to
 reset PHY

On 12/06/2013 10:01 PM, Florian Fainelli wrote:
> Instead of open-coding a PHY reset through the MII BMCR register, use
> phy_init_hw() which does that for us and will also make sure that PHY
> fixups are applied if required. We also remove a call to phy_reset()
> due to the following sequence of calls in the driver:
>
> phy_scan()
> 	-> phy_connect()
> 		-> phy_connect_direct()
> 			-> phy_attach_direct()
> 				-> phy_init_hw()
>
> and we only have a call to phy_init() after phy_scan().
>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
> Changes since v2:
> - improved commit message and explain why phy_reset() can go away
>    entirely

Series tested on mv643xx_eth with Marvell Dove SoC.

Tested-by: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>

>   drivers/net/ethernet/marvell/mv643xx_eth.c | 21 +--------------------
>   1 file changed, 1 insertion(+), 20 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html