netdev - RE: NAPI rescheduling and the delay caused by it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1386638260.30495.339.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 09 Dec 2013 17:17:40 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Zoltan Kiss <zoltan.kiss@...rix.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
	Malcolm Crossley <malcolm.crossley@...rix.com>,
	Jonathan Davies <Jonathan.Davies@...rix.com>,
	Paul Durrant <Paul.Durrant@...rix.com>,
	Wei Liu <wei.liu2@...rix.com>,
	Ian Campbell <Ian.Campbell@...rix.com>
Subject: RE: NAPI rescheduling and the delay caused by it

On Mon, 2013-12-09 at 17:14 -0800, Eric Dumazet wrote:

> > I found another suspect however: my grant mapping patches do the
> > unmapping from the NAPI instance where otherwise we receive the
> > packets from the guest. But this means we call napi_schedule from the
> > zerocopy callback, which can be run by anyone who free up that skb,
> > including an another VIF's RX thread (which actually does the transmit
> > TO the guest). I guess that might be bad.
> 
> Same problem : napi_schedule() is meant to be used from interrupt
> context.
> 

Check commit ec13ee80145ccb95b00e6e610044bbd94a170051
for example.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html