netdev - Re: [PATCH 2/2] tun: remove useless codes in tun_chr_aio_read() and tun

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131210.140036.1328560146971385473.davem@davemloft.net>
Date:	Tue, 10 Dec 2013 14:00:36 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	vyasevich@...il.com
Cc:	zwu.kernel@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, wuzhy@...ux.vnet.ibm.com
Subject: Re: [PATCH 2/2] tun: remove useless codes in tun_chr_aio_read()
 and tun_recvmsg()

From: Vlad Yasevich <vyasevich@...il.com>
Date: Tue, 10 Dec 2013 12:18:09 -0500

> On 12/09/2013 08:36 PM, David Miller wrote:
>> From: Zhi Yong Wu <zwu.kernel@...il.com>
>> Date: Sat,  7 Dec 2013 04:55:00 +0800
>> 
>>> From: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
>>>
>>> By checking related codes, it is impossible that ret > len or total_len,
>>> so we should remove some useless codes in both above functions.
>>>
>>> Signed-off-by: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
>> 
>> Applied.
> 
> Wait a sec.  We want to be able to return a value bigger then len
> to trigger a MSG_TRUNC.  Jason has patches for to fix this.  If you
> apply this, we'll have to re-introduce this code back in.
> 
> Same goes for patch 1/2.

That's fine, right now the code makes no sense as the condition can
never be triggered so there is no harm removing the illogical code
meanwhile.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html