netdev - Re: [PATCH net 1/5] qlcnic: Use correct netif api to enable tx queues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131210.174907.841340337177313599.davem@davemloft.net>
Date:	Tue, 10 Dec 2013 17:49:07 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	himanshu.madhani@...gic.com
Cc:	netdev@...r.kernel.org, Dept_NX_Linux_NIC_Driver@...gic.com
Subject: Re: [PATCH net 1/5] qlcnic: Use correct netif api to enable tx
 queues.

From: Himanshu Madhani <himanshu.madhani@...gic.com>
Date: Tue, 10 Dec 2013 12:33:01 -0500

> From: Himanshu Madhani <himanshu.madhani@...gic.com>
> 
> o commit id 012ec81223aa45d2b80aeafb77392fd1a19c7b10
>   ("qlcnic: Multi Tx queue support for 82xx Series adapter.")
>   enabled multiple tx queue API's for qlcnic driver.
>   During link change event, driver will stop/start Tx queues
>   which manages Link up event is received after Tx context is created
>   driver needs to call netif_tx_wake_all_queues()
> 
> Signed-off-by: Himanshu Madhani <himanshu.madhani@...gic.com>

This is a symptom of the fact that this driver does not manage it's
queues correctly.

When the carrier is marked off, the core networking will not queue
packets to the device.

You should never manage queue state manually in response to link
state changes, netif_carrir_{on,off}() takes care of everything.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html