netdev - Re: [PATCH v2] net: allwinner: emac: Add missing free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131210.180138.15284905537878885.davem@davemloft.net>
Date:	Tue, 10 Dec 2013 18:01:38 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	maxime.ripard@...e-electrons.com
Cc:	linux-arm-kernel@...ts.infradead.org, linux-sunxi@...glegroups.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: allwinner: emac: Add missing free_irq

From: Maxime Ripard <maxime.ripard@...e-electrons.com>
Date: Tue, 10 Dec 2013 19:40:43 +0100

> The sun4i-emac driver uses devm_request_irq at .ndo_open time, but relies on
> the managed device mechanism to actually free it. This causes an issue whenever
> someone wants to restart the interface, the interrupt still being held, and not
> yet released.
> 
> Fall back to using the regular request_irq at .ndo_open time, and introduce a
> free_irq during .ndo_stop.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html