netdev - Re: [PATCHv2 net-next 0/5] pktgen IPsec support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52A6763C.4050101@windriver.com>
Date:	Tue, 10 Dec 2013 10:02:36 +0800
From:	Fan Du <fan.du@...driver.com>
To:	David Miller <davem@...emloft.net>
CC:	<steffen.klassert@...unet.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCHv2 net-next 0/5] pktgen IPsec support



On 2013年12月10日 09:23, David Miller wrote:
> From: Fan Du<fan.du@...driver.com>
> Date: Tue, 10 Dec 2013 09:19:09 +0800
>
>> How it could be usable first and then useful for someone before my fix
>> 9e921193884dd85b4cd68aa18598d8c2f9ad85b9
>> ({pktgen, xfrm} Correct xfrm state lock usage when transforming)???

slip of pen here, should be commit:
3868204d6b89ea373a273e760609cb08020beb1a
("{pktgen, xfrm} Update IPv4 header total len and checksum after transformation")

>> Do you really know what this fix does?
>
> Maybe they didn't care about the checksum being correct in the
> testbed they were using.

Can I just reply to custom "Yes, wrong checksum value and non-decrypted packet
is not big deal when your peer host receiving them"?

> I know Jamal used it when he added the feature.

Please re-consider your approach for this patch set, really.

-- 
浮沉随浪只记今朝笑

--fan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html