netdev - Re: [PATCH] sctp: properly latch and use autoclose value from sock to association

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <E1VqDbx-0006lk-Ka@smtp.tuxdriver.com>
Date:	Mon, 09 Dec 2013 22:03:41 -0500
From:	nhorman@...driver.com
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
	vyasevich@...il.com, wangweidong1@...wei.com
Subject: Re: [PATCH] sctp: properly latch and use autoclose value from sock
 to association

Ok I'll repost when I get out of class tomorrow evening

Neil

On Dec 9, 2013 8:32 PM, David Miller <davem@...emloft.net> wrote:
>
> From: Neil Horman <nhorman@...driver.com> 
> Date: Fri,  6 Dec 2013 10:29:15 -0500 
>
> > @@ -2205,6 +2206,12 @@ static int sctp_setsockopt_autoclose(struct sock *sk, char __user *optval, 
> >  if (copy_from_user(&sp->autoclose, optval, optlen)) 
> >  return -EFAULT; 
> >  
> > + if (sp->autoclose > net->sctp.max_autoclose) { 
> > + pr_warn("Capping autoclose value %d to defined maximum of %lu\n", 
> > + sp->autoclose, net->sctp.max_autoclose); 
> > + sp->autoclose = net->sctp.max_autoclose; 
> > + } 
>
> Please don't add this warning. 
>
> If we already do this for certain setsockopt calls in SCTP, that just 
> means we have bugs to fix. 
>