netdev - Re: [PATCH 3/7] net: vmxnet3: remove unnecessary pci_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <000001cef563$d2638cf0$772aa6d0$%han@samsung.com>
Date:	Tue, 10 Dec 2013 13:53:51 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Shreyas Bhatewara' <sbhatewara@...are.com>
Cc:	"'David S. Miller'" <davem@...emloft.net>, netdev@...r.kernel.org,
	pv-drivers@...are.com, 'Andy King' <acking@...are.com>,
	'Aditya Sarwade' <asarwade@...are.com>,
	'George Zhang' <georgezhang@...are.com>,
	'Dmitry Torokhov' <dtor@...are.com>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH 3/7] net: vmxnet3: remove unnecessary pci_set_drvdata()

On Tuesday, December 10, 2013 1:37 PM, Shreyas Bhatewara wrote:
> On Monday, November 25, 2013 11:05:23 AM Jingoo Han wrote:
> > The driver core clears the driver data to NULL after device_release
> > or on probe failure. Thus, it is not needed to manually clear the
> > device driver data to NULL.
> >
> > Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> 
> Signed-off-by: Shreyas N Bhatewara <sbhatewara@...are.com>

(+cc Dmitry Torokhov)

Hi Shreyas Bhatewara,

It may be 'Acked-by' instead of 'Signed-off-by', right?

Also, I missed 'Acked-by' from Dmitry Torokhov.
Acked-by: Dmitry Torokhov <dtor@...are.com>

So, Dmitry Torokhov's 'Acked-by' should be added,
when this commit is merged.

Thank you for your feedback. :-)

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html