netdev - Re: [PATCH 1/2] vxlan: remove vxlan_group_used in vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 Dec 2013 14:26:30 +0800
From:	Gao feng <gaofeng@...fujitsu.com>
To:	David Miller <davem@...emloft.net>
CC:	stephen@...workplumber.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] vxlan: remove vxlan_group_used in vxlan_open

On 12/10/2013 08:32 AM, David Miller wrote:
> From: Gao feng <gaofeng@...fujitsu.com>
> Date: Thu, 5 Dec 2013 17:01:35 +0800
> 
>> In vxlan_open, vxlan_group_used always returns true,
>> because the state of the vxlan deivces which we want
>> to open has alreay been running. and it has already
>> in vxlan_list.
>>
>> Since ip_mc_join_group takes care of the reference
>> problem. we can remove vxlan_group_used here, let
>> ip_mc_join_group resolve the reference problem.
>>
>> Signed-off-by: Gao feng <gaofeng@...fujitsu.com>
> 
> "already" is misspelled in this commit message.
> 
> Please describe what "the reference problem" actually is.
> 

There is no reference bug here. just means we needn't to take
care of the reference of ip_mc_list, vxlan_group_used has no use here.

>> @@ -1943,8 +1943,7 @@ static int vxlan_open(struct net_device *dev)
>>  	if (!vs)
>>  		return -ENOTCONN;
>>  
>> -	if (vxlan_addr_multicast(&vxlan->default_dst.remote_ip) &&
>> -	    vxlan_group_used(vn, &vxlan->default_dst.remote_ip)) {
>> +	if (vxlan_addr_multicast(&vxlan->default_dst.remote_ip)) {
> 
> This makes "vn" unused, please remove it.
> 
> The compiler even warns about this, are you watching the build
> after making changes for messages like that?

Sorry for this. I will take care of this.

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html