[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAJZOPZJJdc_r88Mp0Y5of42dG51yBnsrwVHyuGxzC_XCYXjPKg@mail.gmail.com>
Date: Tue, 10 Dec 2013 09:22:35 +0200
From: Or Gerlitz <or.gerlitz@...il.com>
To: Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
David Miller <davem@...emloft.net>,
Anjali Singhai Jain <anjali.singhai@...el.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"gospo@...hat.com" <gospo@...hat.com>, sassmann@...hat.com
Subject: Re: [net-next 09/14] i40e: Enable all PCTYPEs except FCOE for RSS.
On Tue, Dec 10, 2013 at 12:05 AM, Or Gerlitz <or.gerlitz@...il.com> wrote:
> On Sat, Dec 7, 2013 at 10:55 PM, Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:
>> On Sun, 2013-12-08 at 00:20 +0300, Sergei Shtylyov wrote:
>>> Greg KH seems to be persistent in being negative towards its use. I also
>>> react semi-automatically whenever I see it, asking to remove it. Anyway, it's
>>> really DaveM's issue whether to allow it.
>>> The main issue with it is that it doesn't contain any useful information
>>> to an ordinary person browsing kernel commits, it's exactly for the internal use only.
>> Well, I would disagree on the point that it would be for internal use
>> only. While it is a internal git hash, it helps us support the Linux
>> community by helping us track the internal history of the patch for
>> support and changes. So customers could give us either the Linux kernel
>> hash (in which turn we would find the internal hash id information from
>> the patch description) or could give us the I<hash>. So you are right,
>> we would be the ones using the information to help support you and
>> everyone else.
> Shouldn't vendors actually seek to do that the other way around? e.g
> find a way to link plain upstream commit Hash to their feature request
> / bug reports / development trees and not plant the IHash on upstream? just thinking out loud.
e.g what's wrong with having the maintainer of the internal git tree
do "git reword" for the internal
commit after it has been accepted into upstream and adding there the
upstream hash. This will
create a link with the Internal Change-Id: w.o putting vendors'
change-Id: on upstream commits, thoughts?
Or.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists