netdev - Re: [PATCH v2] net: smc91x: Fix device tree based configuration so it's usable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131211.154426.2252395344655389568.davem@davemloft.net>
Date:	Wed, 11 Dec 2013 15:44:26 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	nm@...com
Cc:	tony@...mide.com, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, nico@...xnic.net, mark.rutland@....com
Subject: Re: [PATCH v2] net: smc91x: Fix device tree based configuration so
 it's usable

From: Nishanth Menon <nm@...com>
Date: Wed, 11 Dec 2013 12:24:38 -0600

> Hi Tony,
> On 11/27/2013 12:56 PM, Tony Lindgren wrote:
>> Commit 89ce376c6bdc (drivers/net: Use of_match_ptr() macro in smc91x.c)
>> added minimal device tree support to smc91x, but it's not working on
>> many platforms because of the lack of some key configuration bits.
>> 
>> Fix the issue by parsing the necessary configuration like the
>> smc911x driver is doing. As most smc91x users seem to use 16-bit
>> access, let's default to that if no reg-io-width is specified.
>> 
>> Cc: Nicolas Pitre <nico@...xnic.net>
>> Cc: Mark Rutland <mark.rutland@....com>
>> Cc: netdev@...r.kernel.org
>> Cc: devicetree@...r.kernel.org
>> Signed-off-by: Tony Lindgren <tony@...mide.com>
>> 
>> ---
>> 
>> Device tree folks, any objection to using the reg-io-width property
>> as a mask here?
>> 
>> Looks like we can use reg-io-width as a mask too if needed, it seems
>> to play fine with combinations of 1 = 8-bit, 2 = 16-bit, 4 = 32-bit
>> and so on.
>> 
>> I would like to see this merged during the -rc cycle as this makes
>> my test devices behave the same way when booted in legacy platform
>> data mode compared to when booted with device tree.
>> 
> please feel free to add my:
> Acked-by: Nishanth Menon <nm@...com>
> 
> Also tested on SDP2430:
> http://pastebin.mozilla.org/3756403

That patch needs changes, it adds a warning when CONFIG_OF is disabled
because the variable 'np' only gets used in the CONFIG_OF protected
code block yet is declared unconditionally.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html