netdev - Re: [PATCH v3 net-next] 8390 : Replace ei_debug with msg_enable/NETIF_MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131211.163456.285803377239228949.davem@davemloft.net>
Date:	Wed, 11 Dec 2013 16:34:56 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	tedheadster@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next] 8390 : Replace ei_debug with
 msg_enable/NETIF_MSG_* feature

From: Matthew Whitehead <tedheadster@...il.com>
Date: Wed, 11 Dec 2013 16:03:38 -0500

> @@ -133,11 +139,11 @@ struct net_device * __init apne_probe(int unit)
>  	if ( !(AMIGAHW_PRESENT(PCMCIA)) )
>  		return ERR_PTR(-ENODEV);
>  
> -	printk("Looking for PCMCIA ethernet card : ");
> +	printk(KERN_INFO "Looking for PCMCIA ethernet card : ");

"pr_info()"

> @@ -536,8 +546,8 @@ static irqreturn_t apne_interrupt(int irq, void *dev_id)
>          pcmcia_ack_int(pcmcia_intreq);
>          return IRQ_NONE;
>      }
> -    if (ei_debug > 3)
> -        printk("pcmcia intreq = %x\n", pcmcia_intreq);
> +    if (apne_msg_enable & NETIF_MSG_INTR)
> +	printk(KERN_DEBUG "pcmcia intreq = %x\n", pcmcia_intreq);
>      pcmcia_disable_irq();			/* to get rid of the sti() within ei_interrupt */
>      ei_interrupt(irq, dev_id);
>      pcmcia_ack_int(pcmcia_get_intreq());

Maybe "pr_debug()"?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html