netdev - Re: [PATCH v4 net-next] 8390 : Replace ei_debug with msg_enable/NETIF_MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131211.171224.2111686395095015308.davem@davemloft.net>
Date:	Wed, 11 Dec 2013 17:12:24 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	tedheadster@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v4 net-next] 8390 : Replace ei_debug with
 msg_enable/NETIF_MSG_* feature

From: Matthew Whitehead <tedheadster@...il.com>
Date: Wed, 11 Dec 2013 17:00:59 -0500

> Removed the shared ei_debug variable. Replaced it by adding u32 msg_enable to
> the private struct ei_device. Now each 8390 ethernet instance has a per-device
> logging variable.
> 
> Changed older style printk() calls to more canonical forms.
> 
> Tested on: ne, ne2k-pci, smc-ultra, and wd hardware.
> 
> V4.0
> - Substituted pr_info() and pr_debug() for printk() KERN_INFO and KERN_DEBUG
> 
> V3.0
> - Checked for cases where pr_cont() was most appropriate choice.
> - Changed module parameter from 'debug' to 'msg_enable' because debug was
> no longer the best description.
> 
> V2.0
> - Changed netif_msg_(drv|probe|ifdown|rx_err|tx_err|tx_queued|intr|rx_status|hw)
> to netif_(dbg|info|warn|err) where possible.
> 
> Signed-off-by: Matthew Whitehead <tedheadster@...il.com>

Applied, but there was some trailing whitespace I had to edit out while
applying this, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html