netdev - Re: [PATCH net-next] net_sched: add messages to distinguish errors when modify qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52A7CFCD.5010906@huawei.com>
Date:	Wed, 11 Dec 2013 10:37:01 +0800
From:	Yang Yingliang <yangyingliang@...wei.com>
To:	David Miller <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net_sched: add messages to distinguish errors
 when modify qdisc

On 2013/12/11 2:47, David Miller wrote:
> From: Yang Yingliang <yangyingliang@...wei.com>
> Date: Tue, 10 Dec 2013 16:49:00 +0800
> 
>> When tc_modify_qdisc return EINVAL, user cannot distinguish
>> errors easliy. Add some messages to make it easier.
>>
>> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> 
> There is no chance I am ever going to apply a patch like this one,
> sorry.
> 
> If the indication to userspace is not fine grained enough, fix that.
> Don't spam the kernel log with random messages triggerable by the
> user.
> 
> 
Ok, thanks!

Then how about change the errno, is that ok ?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html