netdev - Re: [PATCH] net: unix: allow set_peek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131210.214546.2076606671956419677.davem@davemloft.net>
Date:	Tue, 10 Dec 2013 21:45:46 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	xemul@...allels.com
Cc:	sasha.levin@...cle.com, edumazet@...gle.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: unix: allow set_peek_off to fail

From: Pavel Emelyanov <xemul@...allels.com>
Date: Mon, 9 Dec 2013 11:32:46 +0400

> On 12/08/2013 02:26 AM, Sasha Levin wrote:
>> unix_dgram_recvmsg() will hold the readlock of the socket until recv
>> is complete.
>> 
>> In the same time, we may try to setsockopt(SO_PEEK_OFF) which will hang until
>> unix_dgram_recvmsg() will complete (which can take a while) without allowing
>> us to break out of it, triggering a hung task spew.
>> 
>> Instead, allow set_peek_off to fail, this way userspace will not hang.
>> 
>> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>
> 
> Acked-by: Pavel Emelyanov <xemul@...allels.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html