netdev - Re: [PATCH 0/2] Display adjacent switch port's attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Dec 2013 14:57:18 +0100
From:	Stefan Raspl <raspl@...ux.vnet.ibm.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
CC:	davem@...emloft.net, bhutchings@...arflare.com,
	blaschka@...ux.vnet.ibm.com, netdev@...r.kernel.org,
	linux-s390@...r.kernel.org
Subject: Re: [PATCH 0/2] Display adjacent switch port's attributes

Am 11.12.2013 21:13, schrieb Stephen Hemminger:
> On Wed, 11 Dec 2013 14:28:58 +0100
> Stefan Raspl <raspl@...ux.vnet.ibm.com> wrote:
> 
>> This patch series adds a new callback for ethtool to display the adjacent switch
>> port's attributes, as perceived by the NIC, e.g. through respective LLDP message
>> exchanges.
>> A patch for the qeth device driver provides a sample exploiter for the new
>> functionality.
>> A new option for ethtool to display the settings will be posted in a separate
>> patch.
>>
>> Best regards,
>> Stefan Raspl
>>
>> Stefan Raspl (2):
>>   ethtool: Add callback to indicate adjacent switch port attributes
>>   qeth: Display adjacent switch port attributes in ethtool
>>
>>  drivers/s390/net/qeth_core.h      |  7 ++++
>>  drivers/s390/net/qeth_core_main.c | 79 +++++++++++++++++++++++++++++++++++++++
>>  drivers/s390/net/qeth_core_mpc.h  | 17 +++++++++
>>  drivers/s390/net/qeth_l2_main.c   |  1 +
>>  drivers/s390/net/qeth_l3_main.c   |  1 +
>>  include/linux/ethtool.h           |  3 ++
>>  include/uapi/linux/ethtool.h      | 35 +++++++++++++++++
>>  net/core/ethtool.c                | 22 +++++++++++
>>  8 files changed, 165 insertions(+)
>>
> 
> Why more ethtool and not netlink? ethtool is a brittle interface, non-extensible
> and does not support notifications of changes.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

I agree, netlink would certainly be nice. But ethtool is the
de-facto standard for now, and there doesn't seem to be a
netlink-based alternative in sight - or is there?
Offering a netlink based tool seems to be a different discussion,
and if that takes shape, existing ethtool functionality (including
this series) can and should be migrated.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html