netdev - Re: [PATCH] ipv6: fix incorrect type in initializer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Dec 2013 18:36:06 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Florent Fourcot <florent.fourcot@...t-bretagne.fr>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: fix incorrect type in initializer

Hello.

On 12-12-2013 14:41, Florent Fourcot wrote:

    s/initializer/declaration/.

> Introduced by 1397ed35f22d7c30d0b89ba74b6b7829220dfcfd
>    "ipv6: add flowinfo for tcp6 pkt_options for all cases"

> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Signed-off-by: Florent Fourcot <florent.fourcot@...t-bretagne.fr>
> ---
>   net/ipv6/ipv6_sockglue.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c
> index bc4d8a2..dac04d2 100644
> --- a/net/ipv6/ipv6_sockglue.c
> +++ b/net/ipv6/ipv6_sockglue.c
> @@ -1035,7 +1035,7 @@ static int do_ipv6_getsockopt(struct sock *sk, int level, int optname,
>   				put_cmsg(&msg, SOL_IPV6, IPV6_2292HOPLIMIT, sizeof(hlim), &hlim);
>   			}
>   			if (np->rxopt.bits.rxflow) {
> -				int flowinfo = np->rcv_flowinfo;
> +				__be32 flowinfo = np->rcv_flowinfo;

    Empty line wouldn't hurt here, after declaration.

>   				put_cmsg(&msg, SOL_IPV6, IPV6_FLOWINFO, sizeof(flowinfo), &flowinfo);

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html