lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Dec 2013 12:31:53 +0800 From: Chen-Yu Tsai <wens@...e.org> To: Maxime Ripard <maxime.ripard@...e-electrons.com> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>, netdev <netdev@...r.kernel.org>, Rob Herring <rob.herring@...xeda.com>, devicetree <devicetree@...r.kernel.org>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, linux-kernel <linux-kernel@...r.kernel.org>, linux-sunxi <linux-sunxi@...glegroups.com>, Srinivas Kandagatla <srinivas.kandagatla@...com> Subject: Re: [PATCH 01/10] net: stmmac: Enable stmmac main clock when probing hardware Hi, On Wed, Dec 11, 2013 at 4:05 AM, Maxime Ripard <maxime.ripard@...e-electrons.com> wrote: > Hi, > > On Mon, Dec 09, 2013 at 10:43:29AM +0800, Chen-Yu Tsai wrote: >> >> @@ -2759,15 +2760,18 @@ struct stmmac_priv *stmmac_dvr_probe(struct device *device, >> >> } >> >> } >> >> >> >> + clk_disable_unprepare(priv->stmmac_clk); >> >> + >> > >> > Hu? Why do you disable the clock? don't you need it afterwards? >> >> The clock is enabled in *_open (when the network interface is used), >> and disabled in *_close. > > Maybe it is the real issue then. > > Why don't you move the clk_disable to _remove then? I wasn't sure this was the proper way. However, looking around, it seems other drivers enable the clock in, _probe, and disable it in _remove. I will modify stmmac to do so as well. ChenYu -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists