netdev - Re: [PATCH net-next v2 2/6] net_sched: act: use standard struct list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABa6K_H_f_9sS4pH2gE2YD_KUHOVMGRwpy1x8Q-i3mFDEmQXjA@mail.gmail.com>
Date:	Fri, 13 Dec 2013 14:32:18 +0800
From:	Changli Gao <xiaosuo@...il.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	Linux Netdev List <netdev@...r.kernel.org>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next v2 2/6] net_sched: act: use standard struct list_head

On Fri, Dec 13, 2013 at 12:56 PM, Cong Wang <xiyou.wangcong@...il.com> wrote:
>
> @@ -85,12 +86,18 @@ static inline int
>  tcf_exts_is_predicative(struct tcf_exts *exts)
>  {
>  #ifdef CONFIG_NET_CLS_ACT
> -       return !!exts->action;
> +       return list_empty(&exts->head);
>  #else
>         return 0;
>  #endif
>  }
>

You missed a "!".

Thanks.

-- 
Regards,
Changli Gao(xiaosuo@...il.com)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html