netdev - Re: [PATCH net-next v2 0/8] bonding: add more netlink attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131214.010836.1667099923747304358.davem@davemloft.net>
Date:	Sat, 14 Dec 2013 01:08:36 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sfeldma@...ulusnetworks.com
Cc:	vfalico@...hat.com, fubar@...ibm.com, andy@...yhouse.net,
	netdev@...r.kernel.org, roopa@...ulusnetworks.com,
	shm@...ulusnetworks.com
Subject: Re: [PATCH net-next v2 0/8] bonding: add more netlink attributes

From: Scott Feldman <sfeldma@...ulusnetworks.com>
Date: Thu, 12 Dec 2013 14:09:48 -0800

> v2:
> 
> Addressed v1 review comments.  In particular, Jay's concern about
> current sysfs ordering limitations carrying over to iproute.  Netlink
> attributes are processed in a priority order in
> bond_netlink.c:bond_changelink().  Lower priority attributes can't undo
> higher priority attributes when attempting to set both with iproute
> command.  For example, this command will fail:
> 
>   ip link add bond1 type bond mode active-backup miimon 10 arp_interval 10
> 
> Because we're trying to create a new bond to use incompatible miimon
> and ARP interval attributes.  However, if attributes are applied
> one-at-a-time, previously applied attributes can be overridden:
> 
>   ip link add bond1 type bond mode active-backup miimon 10
>   ip link set dev bond1 type bond arp_interval 10
> 
> These two commands succeed.  The bond is first created to use miimon.
> Next, the bond is converted to use ARP interval, which undoes miimon.
> 
> v1:
> 
> Following Jiri Pirko's lead, add more bonding netlink attributes.  Sending
> matching iproute2 patch separately.  sysfs access to attributes is
> retained.

Series applied, thanks Scott.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html