netdev - Re: [PATCH net-next] pkt_sched: set root qdisc before change() in attach_default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131214.012030.1055733981305952689.davem@davemloft.net>
Date:	Sat, 14 Dec 2013 01:20:30 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] pkt_sched: set root qdisc before change() in
 attach_default_qdiscs()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 12 Dec 2013 15:41:56 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> After commit 95dc19299f74 ("pkt_sched: give visibility to mq slave
> qdiscs") we call disc_list_add() while the device qdisc might be
> the noop_qdisc one.
> 
> This shows up as duplicates in "tc qdisc show", as all inactive devices
> point to noop_qdisc.
> 
> Fix this by setting dev->qdisc to the new qdisc before calling
> ops->change() in attach_default_qdiscs()
> 
> Add a WARN_ON_ONCE() to catch any future similar problem.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html