netdev - Re: [PATCH 1/3] can: mcp251x: Convert driver to use common clk framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1387028123.883417068@f330.i.mail.ru>
Date:	Sat, 14 Dec 2013 17:35:23 +0400
From:	Alexander Shiyan <shc_work@...l.ru>
To:	Marc Kleine-Budde <mkl@...gutronix.de>
Cc:	Russell King <linux@....linux.org.uk>,
	dbaryshkov@...il.com, netdev@...r.kernel.org,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	linux-can@...r.kernel.org,
	Wolfgang Grandegger <wg@...ndegger.com>,
	Sascha Hauer <kernel@...gutronix.de>,
	Eric Miao <eric.y.miao@...il.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] can: mcp251x: Convert driver to use common clk framework

> On 12/14/2013 06:15 AM, Alexander Shiyan wrote:
> > On Wed, 13 Nov 2013 10:04:39 +0100
> > Marc Kleine-Budde <mkl@...gutronix.de> wrote:
> > 
> >> as this series adds device tree bindings, please add
> >> devicetree@...r.kernel.org on Cc for the whole series.
> >>
> >> On 11/13/2013 09:42 AM, Alexander Shiyan wrote:
> >>> This patch converts mcp251x driver to using common clk framework
> >>> for getting input frequency. The change was made for the preparation
> >>> of the driver work with the devicetree. As a result private header
> >>> for the driver is eliminated.
> >>> Additionally, all existing users of the driver was converted to use
> >>> this feature.
> >>>
> >>> Signed-off-by: Alexander Shiyan <shc_work@...l.ru>
> >>
> >> Looks good from my point of view. I'll take the whole series via the
> >> linux-can tree, if there are no objections. I'd like to have the pxa and
> >> imx maintainer's Ack and an Ack from the DT list.
> >>
> >> Acked-by: Marc Kleine-Budde <mkl@...gutronix.de>
> > 
> > Ping. Resend?
> 
> Is Dmitry's comment still valid?
> 
> PXA does not employ COMMON_CLK yet (WIP locally, but it is not finished
> yet), so clk_register_fixed() will probably fail.

OK, I'll make another version then.

---