netdev - RE: [PATCH -next] xen-netback: fix fragments error handling in checksum_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9AAE0902D5BC7E449B7C8E4E778ABCD01B4F4C@AMSPEX01CL01.citrite.net>
Date:	Mon, 16 Dec 2013 09:40:37 +0000
From:	Paul Durrant <Paul.Durrant@...rix.com>
To:	Wei Yongjun <weiyj.lk@...il.com>,
	Ian Campbell <Ian.Campbell@...rix.com>,
	Wei Liu <wei.liu2@...rix.com>,
	Zoltan Kiss <zoltan.kiss@...rix.com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	"yongjun_wei@...ndmicro.com.cn" <yongjun_wei@...ndmicro.com.cn>,
	"xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH -next] xen-netback: fix fragments error handling in
 checksum_setup_ip()

> -----Original Message-----
> From: Wei Yongjun [mailto:weiyj.lk@...il.com]
> Sent: 16 December 2013 02:45
> To: Ian Campbell; Wei Liu; Paul Durrant; Zoltan Kiss; davem@...emloft.net
> Cc: yongjun_wei@...ndmicro.com.cn; xen-devel@...ts.xenproject.org;
> netdev@...r.kernel.org
> Subject: [PATCH -next] xen-netback: fix fragments error handling in
> checksum_setup_ip()
> 
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Fix to return -EPROTO error if fragments detected in checksum_setup_ip().
> 
> Fixes: 1431fb31ecba ('xen-netback: fix fragment detection in checksum
> setup')
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/net/xen-netback/netback.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-
> netback/netback.c
> index 800496b..773b731 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -1099,6 +1099,9 @@ static int checksum_setup_ip(struct xenvif *vif,
> struct sk_buff *skb,
> 
>  	err = -EPROTO;
> 
> +	if (fragment)
> +		goto out;
> +

Good grief. This hunk must have got lost from my original patch. My old tree has it there. So...

Reviewed-by: Paul Durrant <paul.durrant@...rix.com>

>  	switch (ip_hdr(skb)->protocol) {
>  	case IPPROTO_TCP:
>  		err = maybe_pull_tail(skb,

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html