netdev - Re: [PATCH net-next] xfrm: Namespacify xfrm_policy_sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131216122325.GI31491@secunet.com>
Date:	Mon, 16 Dec 2013 13:23:25 +0100
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Fan Du <fan.du@...driver.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] xfrm: Namespacify xfrm_policy_sk_bundles

On Mon, Dec 16, 2013 at 06:26:08PM +0800, Fan Du wrote:
> 
> And also since xfrm_policy_sk_bundles is only used in xfrm_lookup and
> __xfrm_garbage_collect, both in process context, no reason we should turn
> BH off.

Are you sure about that?

__xfrm_garbage_collect() is called via dst_alloc() which can be called
from softirq and process context.


> In addition we can use xchg to avoid the spinlock, inspired by
> discussion in: http://marc.info/?l=linux-netdev&m=138713363113003&w=2
> 
> Signed-off-by: Fan Du <fan.du@...driver.com>
> ---
> Please note this patch is based on commit 283bc9f35bbbcb0e9ab4e6d2427da7f9f710d52d
> ("xfrm: Namespacify xfrm state/policy locks"), which is still in ipsec-next tree.
>
 
You could use

Subject: [PATCH ipsec-next] xfrm: Namespacify xfrm_policy_sk_bundles

then everybody should know on which tree it is based.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html