netdev - Re: [PATCH -next] xen-netback: fix some error return code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1387201238.10247.37.camel@kazak.uk.xensource.com>
Date:	Mon, 16 Dec 2013 13:40:38 +0000
From:	Ian Campbell <Ian.Campbell@...rix.com>
To:	Wei Liu <wei.liu2@...rix.com>
CC:	Wei Yongjun <weiyj.lk@...il.com>, <yongjun_wei@...ndmicro.com.cn>,
	<xen-devel@...ts.xenproject.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH -next] xen-netback: fix some error return code

On Mon, 2013-12-16 at 13:13 +0000, Wei Liu wrote:
> On Mon, Dec 16, 2013 at 01:49:29PM +0800, Wei Yongjun wrote:
> > From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> > 
> > Fix to return -EPROTO error code instead of 0(overwrite by maybe_pull_tail())
> > if skb_partial_csum_set() return false.
> > 
> > Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> > ---
> >  drivers/net/xen-netback/netback.c | 16 ++++++++++++----
> >  1 file changed, 12 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> > index 800496b..b16daa7 100644
> > --- a/drivers/net/xen-netback/netback.c
> > +++ b/drivers/net/xen-netback/netback.c
> > @@ -1108,8 +1108,10 @@ static int checksum_setup_ip(struct xenvif *vif, struct sk_buff *skb,
> >  			goto out;
> >  
> >  		if (!skb_partial_csum_set(skb, off,
> > -					  offsetof(struct tcphdr, check)))
> > +					  offsetof(struct tcphdr, check))) {
> > +			err = -EPROTO;
> 
> Why is this needed? It is set to -EPROTO before the 'switch'.

Agreed.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html