netdev - Re: [PATCH net-next] ipv6: use interface mtu for determining if packet-too-big should be send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131216140124.GA5164@order.stressinduktion.org>
Date:	Mon, 16 Dec 2013 15:01:24 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ipv6: use interface mtu for determining if packet-too-big should be send

On Mon, Dec 16, 2013 at 05:49:42AM -0800, Eric Dumazet wrote:
> On Mon, 2013-12-16 at 09:09 +0100, Hannes Frederic Sowa wrote:
> > IPv6 forwarding path should also not depend on the path mtu values to
> > judge if a packet should get dropped and an ICMP PTB should be returned.
> > 
> > For the accompanying change in IPv4, have a look at "ipv4: introduce
> > ip_dst_mtu_secure and protect forwarding path against pmtu spoofing".
> > 
> 
> No commit sha1 (truncated to 12 digits) ?

The patch is not yet committed.

> > I needed to move in6_dev_dev around to keep ip6_dst_mtu_secure as a static
> > inline function in the header and to keep header dependencies happy.
> > 
> > For the IPv4 change, see patch "ipv4: introduce ip_dst_mtu_secure and
> > protect forwarding path against pmtu spoofing".
> 
> Redundant sentence ?

Hehe, I have no idea how that happend. :)

> And no documentation for the new setting.
> 
> git grep -n forward_use_pmtu Documentation

The IPv4 patch introduces the documentation for the flag but is in the
wrong section (IPv4). I'll send a v2 later today and will duplicate it
for the IPv6 section.

Thanks,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html