netdev - Re: [PATCH] SCTP: Reduce log spamming for sctp setsockopt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52AF18B7.6050602@redhat.com>
Date:	Mon, 16 Dec 2013 16:13:59 +0100
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Joe Perches <joe@...ches.com>
CC:	Neil Horman <nhorman@...driver.com>, linux-sctp@...r.kernel.org,
	Vlad Yasevich <vyasevich@...il.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] SCTP: Reduce log spamming for sctp setsockopt

On 12/16/2013 04:03 PM, Joe Perches wrote:
> On Mon, 2013-12-16 at 09:44 -0500, Neil Horman wrote:
>> During a recent discussion regarding some sctp socket options, it was noted that
>> we have several points at which we issue log warnings that can be flooded at an
>> unbounded rate by any user.  Fix this by converting all the pr_warns in the
>> sctp_setsockopt path to be pr_warn_ratelimited.
>
> trivial note:
[...]
>> @@ -5311,8 +5311,8 @@ static int sctp_getsockopt_maxburst(struct sock *sk, int len,
> []
>> +		pr_warn_ratelimited("Use of int in max_burst socket option deprecated\n");
>> +		pr_warn_ratelimited("Use struct sctp_assoc_value instead\n");
>
> Perhaps a dedicated "deprecated" warning function
> to centralize these?
>
> void _sctp_warn_deprecated(const char *func, const char *from, const char *to);
> {
> 	etc.
> }
> #define sctp_warn_deprecated(from, to)		\
> 	_sctp_warn_deprecated(__func__, from, to)

If so, then this should better get even more "centralized" ... as e.g.
pr_warn_deprecated() [which internally is ratelimited]. I don't see the
point why only SCTP should have this special-cased.

> and use
>
> 		sctp_warn_deprecated("struct sctp_assoc_value", "struct sctp_sack_info");
> 		sctp_warn_deprecated("int", "");
> 		sctp_warn_deprecated("int", "struct sctp_assoc_value");
> 		sctp_warn_deprecated("struct sctp_assoc_value", "struct sctp_sack_info");
> 		sctp_warn_deprecated("int", "struct sctp_assoc_value");
> 		sctp_warn_deprecated("int", "struct sctp_assoc_value");
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html