netdev - Re: [PATCH net-next] xen-netback: add gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1387218237.19078.247.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 16 Dec 2013 10:23:57 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Paul Durrant <paul.durrant@...rix.com>
Cc:	xen-devel@...ts.xen.org, netdev@...r.kernel.org,
	Wei Liu <wei.liu2@...rix.com>,
	Ian Campbell <ian.campbell@...rix.com>,
	David Vrabel <david.vrabel@...rix.com>
Subject: Re: [PATCH net-next] xen-netback: add gso_segs calculation

On Mon, 2013-12-16 at 17:20 +0000, Paul Durrant wrote:
> netback already has code which parses IPv4 and v6 headers to set up checksum
> offsets and these are always applied to GSO packets being sent from
> frontends. It's therefore suboptimal that GSOs are being marked
> SKB_GSO_DODGY to defer the gso_segs calculation when netback already has all
> necessary information to hand to do the calculation. This patch adds that
> calculation.
> 
> Signed-off-by: Paul Durrant <paul.durrant@...rix.com>
> Cc: Wei Liu <wei.liu2@...rix.com>
> Cc: Ian Campbell <ian.campbell@...rix.com>
> Cc: David Vrabel <david.vrabel@...rix.com>
> ---
>  drivers/net/xen-netback/netback.c |   17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> index 904e497..0af8d97 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -1043,10 +1043,7 @@ static int xenvif_set_skb_gso(struct xenvif *vif,
>  	}
>  
>  	skb_shinfo(skb)->gso_size = gso->u.gso.size;
> -
> -	/* Header must be checked, and gso_segs computed. */
> -	skb_shinfo(skb)->gso_type |= SKB_GSO_DODGY;
> -	skb_shinfo(skb)->gso_segs = 0;
> +	/* gso_segs will be calculated later */
>  
>  	return 0;
>  }
> @@ -1582,6 +1579,18 @@ static int xenvif_tx_submit(struct xenvif *vif, int budget)
>  
>  		skb_probe_transport_header(skb, 0);
>  
> +		/* If the packet is GSO then we will have just set up the
> +		 * transport header offset in checksum_setup so it's now
> +		 * straightforward to calculate gso_segs.
> +		 */
> +		if (skb_is_gso(skb)) {
> +			int mss = skb_shinfo(skb)->gso_size;
> +			int hdrlen = skb->transport_header + tcp_hdrlen(skb);

This means there is no headroom ?

This is not what I am seeing in this driver, as it uses :

skb_reserve(skb, NET_SKB_PAD + NET_IP_ALIGN);

> +
> +			skb_shinfo(skb)->gso_segs =
> +				DIV_ROUND_UP(skb->len - hdrlen, mss);
> +		}
> +
>  		vif->dev->stats.rx_bytes += skb->len;
>  		vif->dev->stats.rx_packets++;
>  


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html