netdev - Re: [RFC] net: distribute vxlan tunneled traffic across multiple TXQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Dec 2013 08:45:26 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Sathya Perla <sathya.perla@...lex.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC] net: distribute vxlan tunneled traffic across multiple
 TXQs

On Tue, 2013-12-17 at 14:10 +0530, Sathya Perla wrote:
> TX traffic is distributed across multiple TXQs using skb->sk->sk_hash.
> For vxlan skbs, the reference to the original socket (skb->sk) is replaced
> with vxlan-sk. Because of this all tunneled traffic ends up only on one TXQ.
> 
> This patch uses the skb->rxhash field to carry the original sk->sk_hash
> value so that it can be used by netdev layer to pick a TXQ. If this approach
> is agreeable then we can change the name of skb->rxhash to skb->hash so that
> it can be used in both RX and TX paths.
> 
> But, after a TXQ is picked based on the skb->rxhash for tunneled traffic,
> it's index cannot be recorded in the original socket as it's reference
> is no longer available in skb. So, the TXQ-index would need to be
> computed (from skb->rxhash) for each skb. Any ideas on how this can be
> avoided?

Real question is : Why vxlan needs to set a skb destructor ?  

skb_orphan(skb) breaks TCP Small queues and FQ/pacing packet scheduler,
plus other things...



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html