netdev - RE: [PATCH net-next] igb: make local functions static and remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 17 Dec 2013 20:03:10 +0000
From:	"Wyborny, Carolyn" <carolyn.wyborny@...el.com>
To:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	Stephen Hemminger <stephen@...workplumber.org>
CC:	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next] igb: make local functions static and remove
 dead code

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org]
> On Behalf Of Jeff Kirsher
> Sent: Monday, December 16, 2013 4:52 PM
> To: Stephen Hemminger
> Cc: e1000-devel@...ts.sourceforge.net; netdev@...r.kernel.org
> Subject: Re: [PATCH net-next] igb: make local functions static and remove dead
> code
> 
> On Thu, 2013-12-12 at 12:09 -0800, Stephen Hemminger wrote:
> > Make local functions static, and remove unused
> > e1000_write_sfp_data_byte.
> >
> > Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
> >
> > ---
> >  drivers/net/ethernet/intel/igb/e1000_82575.c |    6 +++---
> >  drivers/net/ethernet/intel/igb/e1000_i210.c  |   18
> > +++++++++---------
> >  drivers/net/ethernet/intel/igb/e1000_i210.h  |    9 ---------
> >  drivers/net/ethernet/intel/igb/e1000_phy.c   |    2 +-
> >  drivers/net/ethernet/intel/igb/e1000_phy.h   |    1 -
> >  drivers/net/ethernet/intel/igb/igb.h         |    2 --
> >  drivers/net/ethernet/intel/igb/igb_ptp.c     |    6 ++++--
> >  7 files changed, 17 insertions(+), 27 deletions(-)
> 
> Did you compile test this patch?  I am guessing no because we got the following
> compile errors:
>  drivers/net/ethernet/intel/igb/e1000_82575.c:2723: error: static declaration of
> âigb_get_thermal_sensor_data_genericâ follows non-static declaration
>  drivers/net/ethernet/intel/igb/e1000_82575.h:270: note: previous declaration
> of âigb_get_thermal_sensor_data_genericâ was here
>  drivers/net/ethernet/intel/igb/e1000_82575.c:2777: error: static declaration of
> âigb_init_thermal_sensor_thresh_genericâ follows non-static declaration
>  drivers/net/ethernet/intel/igb/e1000_82575.h:269: note: previous declaration
> of âigb_init_thermal_sensor_thresh_genericâ was here
>  make[5]: *** [drivers/net/ethernet/intel/igb/e1000_82575.o] Error 1
>  make[5]: *** Waiting for unfinished jobs....
>  make[4]: *** [drivers/net/ethernet/intel/igb] Error 2
>  make[4]: *** Waiting for unfinished jobs....
>  make[3]: *** [drivers/net/ethernet/intel] Error 2
>  make[2]: *** [drivers/net/ethernet] Error 2
>  make[1]: *** [drivers/net] Error 2
>  make: *** [drivers] Error 2
> 
> I will work on a v2 to fix up these compiling issues.

Please note that removing the igb_get_eee_status_i354 function is the incorrect fix.  There is another bug that is the missing code that uses this function.  I'm working on it.

Thanks,

Carolyn