netdev - Re: [PATCH net] bridge: br_handle_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131217.161323.1528213413550233056.davem@davemloft.net>
Date:	Tue, 17 Dec 2013 16:13:23 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	faecknitz@...splots.de
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] bridge: br_handle_local_finish should not return
 zero

From: Martin Faecknitz <faecknitz@...splots.de>
Date: Sat, 14 Dec 2013 21:52:08 +0100

> br_handle_local_finish is called by NF_HOOK(...) after accepting the packet. If
> the return value of NF_HOOK(...) is zero (i.e. the return value of
> br_handle_local_finish), the packet is passed to the network stack. This
> behavior conflicts with netfilter hooks which return NF_STOLEN/NF_QUEUE. In this
> case, NF_HOOK(...) returns also zero (see nf_hook_slow) but
> br_handle_local_finish was never called. The packet will still passed to the
> network stack.
> 
> Signed-off-by: Martin Faecknitz

This is not a proper Signed-off-by: tag, you have to put your name
as well as your email address, similar to how it appears in the
"From: " field of your outgoing emails.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html